SCAR. Need help

[iNot]

hello, been toying around with scar lately and run into this problem and seem to have problems with understanding what's causing it, let alone fixing it.

i've wrote a custom function to spawn a squad with race based fx, and it all works fine with exception that squad spawns without any fx.

here's the code (look for if _accepter == true then... to find where squad spawns)

Spoiler

--Create squad with race based fx
function Squad_CFRB( playerIndex, sgName, Blueprint, markerOrPos, numsquads, loadout )
--check for errors
	if playerIndex >= World_GetPlayerCount() then
		error"player index can range from 0 to total player count minus 1"
	end
	SGroup_CreateIfNotFound( sgName )
	if ( loadout == nil or loadout == 0 ) then loadout = Squad_GetMaxFromName( Blueprint ) end
	local squad_id = nil
	local fx = nil
	emRace = nil
	local playerId = World_GetPlayerAt( playerIndex )
-- check teh race
	if Player_GetRaceName( playerId ) == "npc_race" then
		if string.find( Blueprint, "chaos" ) ~= nil then 
			emRace = "chaos_marine_race"
		elseif string.find( Blueprint, "eldar" ) ~= nil then 
			emRace = "eldar_race"
		elseif string.find( Blueprint, "guard" ) ~= nil then 
			emRace = "guard_race"
		elseif string.find( Blueprint, "necron" ) ~= nil then 
			emRace = "necron_race"
		elseif string.find( Blueprint, "ork" ) ~= nil then 
			emRace = "ork_race"
		elseif string.find( Blueprint, "space_marine" ) ~= nil then 
			emRace = "space_marine_race"
		elseif string.find( Blueprint, "tau" ) ~= nil then 
			emRace = "tau_race"
		else emRace = "space_marine_race" print"unexpected squad blueprint"
		end
	else
		emRace = Player_GetRaceName( playerId )
	end
	print("race custom "..emRace)
	local sgID = SGroup_FromName( sgName )
-- determine spawn event
	if emRace == "chaos_marine_race" then fx = "data:Art/events/unit_ability_fx/chaos_deep_strike_unit"
	elseif emRace == "eldar_race" then fx = "Data:art\events\unit_ability_fx\eldar_warp_in"
	elseif emRace == "guard_race" then fx = "Data:art\events\unit_upgrade_morale_fx\reinforce_trooper"
	elseif emRace == "necron_race" then fx = "Data:art\events\unit_upgrade_morale_fx\reinforce_necron_trooper"
	elseif emRace == "ork_race" then fx = "Data:art\events\unit_ability_fx\ork_turbo_boost_stormboyz"
	elseif emRace == "space_marine_race" then 
		fx = function()
			local z = SGroup_Count( sgID )
			if first_time == true then
				for i = 1, z do
					SGroup_Add( SGroup_CreateIfNotFound("__dp_squad"..dp_called), SGroup_GetSpawnedSquadAt( sgID, i ) )
				end
				first_time = false
			else
				SGroup_Add( SGroup_CreateIfNotFound("__dp_squad"..dp_called), SGroup_GetSpawnedSquadAt( sgID, z ) )
			end
			Util_DropPodMarker( "__dp_squad"..dp_called, markerOrPos )
			dp_called = dp_called + 1
		end
	elseif emRace == "tau_race" then
		fx = function()
			Entity_CMWA( playerId, "eg_orcaShip"..called, "tau_orca_dropship", markerOrPos, "sp_land" ) called = called + 1
			Util_StartIntel( ENTS.x( playerId, sgName, Blueprint, markerOrPos, numsquads ) )
			squad_id = sgName
		end
	end
	if _accepter(playerIndex) == true then 
		print(fx)
		squad_id = Squad_CreateWithFMRE( playerId, sgName, Blueprint, markerOrPos, fx, numsquads, loadout )
	elseif emRace == "space_marine_race" then
		print"dpIngame"
		squad_id = Util_CreateSquadsAtMarkerEx( playerId, sgName, Blueprint, markerOrPos, numsquads, loadout )
		SGroup_ForEach( sgID, fx )
	end
	return squad_id
end

I have tried using typical spawn and World_FXEventSquad functions but with the same result - no fx is played

all the custom functions it uses:

Spoiler

function _accepter(pIndx)
	local _raceAccepted = false
	local pIdD = World_GetPlayerAt( pIndx )
	local _race = Player_GetRaceName( pIdD )
	local _t_raceT = {"chaos_marine_race","eldar_race","guard_race","necron_race","ork_race"}
	for i = 1, table.getn( _t_raceT ) do 
		if _race == _t_raceT[i] then 
			_raceAccepted = true 
		elseif _race == "npc_race" then
			if emRace == _t_raceT[i] then
				_raceAccepted = true
			end
		end
	end
	return _raceAccepted
end
--------------------------------------------------------------------------
-- basicly creates a squad with specified fx at marker, works just fine
function Squad_CreateWithFMRE( PlayerID, SGroup, SBlueprint, marker, FXEvent, numsquad, loadout )
	if PlayerID == nil then PlayerID = World_GetPlayerAt( 0 ) end
	if numsquad == nil then numsquad = 1 end
	if SBlueprint == nil then error("Squad with this Blueprint doesn't exists:"..SBlueprint) end
	if loadout == nil then loadout = Squad_GetMaxFromName( SBlueprint ) end
	if marker == nil then error("Marker with name "..marker" does not exist") end
	if FXEvent == nil then FXEvent = "data:Art/events/unit_upgrade_morale_fx/reinforce_trooper" end
	if SGroup == nil then SGroup = SGroup_CreateIfNotFound("sg_Custom_sg_for_you") end
	Util_CreateSquadsAtMarkerRandomEx( PlayerID, SGroup, SBlueprint, marker, numsquad, loadout )
	World_FXEventSquad( FXEvent, SGroup_FromName( SGroup ))
	return SGroup_FromName( SGroup )
end

Any help with understanding and fixing issue at hand will be appreciated

[corncobman]

Have you tried using "unit_upgrade_morale_fx/reinforce_trooper" instead of "data:Art/events/unit_upgrade_morale_fx/reinforce_trooper"?

I don't think it's necessary to specify the whole path explicitly, just the subdirectories in the events folder.

-------------------------------------------------------------------------

If you use the [ code ] [ /code ] tags around your text, the tabs are preserved. You can also put spoiler tags around the code tags like this:

[ spoiler ]
[ code ]
Your text here
[ /code ]
[ /spoiler ]

to get this effect:

Spoiler

Blah Blah
    Blah Blah

[iNot]

Thanks for the tip bout code tags

And World_FXEventSquad with the whole path works correctly, so that's not the issue.

[corncobman]

Which races does the FX work / not work for if any?

[iNot]

only sm gets droppoded but that doesnt counts

[Chiu ChunLing]

You've got 'fx = "Data:art\events\unit_ability_fx\eldar_warp_in"' in one place and 'fx = "Data:art\events\unit_upgrade_morale_fx\reinforce_trooper"' elsewhere. Only "/" is correct for specifying paths, as I recall.

You also are calling 'SGroup_ForEach( sgID, fx )' and I have no idea what you think that will do. The first value should probably be squad_id, the SGroupID value you got from spawning the squads in. I didn't see where you defined 'sgID'.

Why don't you use 'Squad_DeepStrikeToPos()' based functions where you can? That should save you some hassle, probably.

[iNot]

SGroup_ForEach gets those marines in drop pods, and well, drop pods them, it's only called for space marine race and does not interferes with anything
As for the "/", i wrote a chaos fx correctly and it doesnt works still.

sgID is defined right after defining race.

I use SGrourforeach just to be safe, Util_DropPodMarker will deep strike the whole sgroup to a marker, when i want only that squad that gets created right now so i define fx as a function that probably will accomplish that, i honestly haven't tried it with creating multiple sm squads and it might not work whatsoever.

Squad_DeepStrikeToPos requires despawning units = no weapon upgrades till they spawned and checking for it to spawn, seems just as messy as what i've got.

[Chiu ChunLing]

Squad_DeepStriketoPos() can use different deep strikes, so you can use it to implement some deepstrikes for races that don't use drop pods.

You've put the comment "-- basicly creates a squad with specified fx at marker, works just fine" on Squad_CreateWithFMRE(), are you positive that this is true? It looks like it should work, but have you actually gotten it to work? Also, are you still using the long path names rather than the short ones, like corncobman mentioned?

[iNot]

I have been using Squad_CreateWithFMRE() for some time now, it does works. Even if it weren't i have tried replacing it with usual Util_CreateSquad... and WorldFXEventSquad.

I also tried using shorter paths and ofc no change.
As for deep striking, nvm mind what i wrote, im just stoopid.

Btw, I wonder where scar functions like W40k and World ones are stored? And wheres the Event for Ork teleport?

EDIT: Tried it on another map, works fine. But I still don't see why.
Here's where the function gets called from

Spoiler

--_ccpNum is identified inside init function and returns total player count
function Game_Start()
_scrace_idp1 = Player_GetRaceName( P1 )
	if Event_IsAnyRunning() == false then
		for i = 0, _ccpNum - 1 do
			if not Cpu_IsCpuPlayer( World_GetPlayerAt( i ) ) then
			if races_table[i] == "chaos_marine_race" then bluep = "chaos_marine_squad"
			elseif races_table[i] == "eldar_race" then bluep = "eldar_squad_dark_reaper_exarch_council"
			elseif races_table[i] == "guard_race" then bluep = "guard_squad_kasrkin_advance_sp"
			elseif races_table[i] == "necron_race" then bluep = "necron_destroyer_squad_advance_sp"
			elseif races_table[i] == "space_marine_race" then bluep = "space_marine_squad_tactical"
			elseif races_table[i] == "tau_race" then bluep = "tau_stealth_team_squad"
			else bluep = "chaos_marine_squad"--"ork_flash_gitz_squad"
			end
			Squad_CFRB( i, "sg_player"..i + 1, bluep, "mkr_spn1", 1, 3 )
			print("sg_player"..i+1)
			end
		end
			print(races_table[0])
Rule_Remove( Game_Start )
Rule_Add( weapons )
	end
end

[Argonaut]

Looking at CutterShanes Heroes rpg mod SCAR code was a fabulous working "tutorial" for me on how to implement various parts of SCAR. Also, IIRC he uses FX on troopers, SGroups and Entities very extensively to display the advancement of the experience. Worth a look.

And I have always used the full path for the events;-

Data:art\events\unit_upgrade_morale_fx\reinforce_trooper.events

(bolding is mine)

And as a side note, shouldn't it be reinforce_marine_trooper.events or reinforce_chaos_trooper.events?

also, be careful which .events can be used on SGroups and Entities. For example, the forced_labour.events is spawned at the Units feet - and consequently doesn't look like it's working. Also, the warp.events for the eldar is much better FX that warp_in fx.

[Chiu ChunLing]

Wait, you tried what on another map and it worked fine? If this code spawns the effects properly on another map then the code works, there is just a problem with the map you're trying to use it on.

[iNot]

Yeah, i've got it to work, thx for the help everyone